Rollup of 4 pull requests by matthiaskrgr · Pull Request #151594 · rust-lang/rust

matthiaskrgr · 2026-01-24T14:35:11Z

Successful merges:

const blocks as a mod item #149174 (const blocks as a mod item)
THIR patterns: Explicitly distinguish &pin from plain &/&mut #151282 (THIR patterns: Explicitly distinguish &pin from plain &/&mut)
miri subtree update #151593 (miri subtree update)
Do not emit errors on non-metaitem diagnostic attr input #151516 (Do not emit errors on non-metaitem diagnostic attr input)

This updates the rust-version file to 63f4513.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@63f4513 Filtered ref: rust-lang/miri@98aa894 Upstream diff: rust-lang/rust@b6fdaf2...63f4513 This merge was created using https://github.com/rust-lang/josh-sync.

Automatic Rustup

This updates the rust-version file to d276646.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@d276646 Filtered ref: rust-lang/miri@e200be9 Upstream diff: rust-lang/rust@63f4513...d276646 This merge was created using https://github.com/rust-lang/josh-sync.

Automatic Rustup

Compile-time variant of shim_sig_arg

This updates the rust-version file to d10ac47.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@d10ac47 Filtered ref: rust-lang/miri@79d95eb Upstream diff: rust-lang/rust@d276646...d10ac47 This merge was created using https://github.com/rust-lang/josh-sync.

Automatic Rustup

…losedir Add test for libc opendir and closedir

update .gitignore to ignore zed files

Unify readdir across Unix targets and add test

readdir: also emit the special directory entries . and ..

windows shims: throw unsupported error for DuplicateHandle on pseudo handle

…e,ytmimi `const` blocks as a `mod` item Tracking issue: rust-lang#149226 This adds support for writing `const { ... }` as an item in a module. In the current implementation, this is a unique AST item that gets lowered to `const _: () = const { ... };` in HIR. rustfmt support included. TODO: - `pub const { ... }` does not make sense (see rust-lang#147136). Reject it. Should this be rejected by the parser or smth? - Improve diagnostics (preferably they should not mention the fake `_` ident).

THIR patterns: Explicitly distinguish `&pin` from plain `&`/`&mut` Currently, `thir::PatKind::Deref` is used for ordinary `&`/`&mut` patterns, and also for `&pin const` and `&pin mut` patterns under `feature(pin_ergonomics)`. The only way to distinguish between them is by inspecting the `Ty` attached to the pattern node. That's non-obvious, making it easy to miss, and is also a bit confusing to read when it does occur. This PR therefore adds an explicit `pin: hir::Pinnedness` field to `thir::PatKind::Deref`, to explicitly distinguish pin-deref nodes from ordinary builtin-deref nodes. (I'm not deeply familiar with the future of pin-patterns, so I'm not sure whether that information is best carried as a field or as a separate `PatKind`, but I think this approach is at least an improvement over the status quo.) r? Nadrieril (or compiler)

@ghost

miri subtree update Subtree update of `miri` to rust-lang/miri@d4afb41. Created using https://github.com/rust-lang/josh-sync. r? @ghost

@JonathanBrouwer

…nn,jonathanbrouwer Do not emit errors on non-metaitem diagnostic attr input This unblocks porting over diagnostic attributes by properly addressing rust-lang#151056 (comment) r? @JonathanBrouwer

matthiaskrgr · 2026-01-24T14:35:39Z

@bors r+ rollup=never p=5

rust-bors · 2026-01-24T14:35:43Z

📌 Commit ac8e7f2 has been approved by matthiaskrgr

It is now in the queue for this repository.

rust-bors · 2026-01-24T18:06:11Z

☀️ Test successful - CI
Approved by: matthiaskrgr
Duration: 3h 13m 21s
Pushing 021fc25 to main...

rust-timer · 2026-01-24T18:07:21Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#149174	`const` blocks as a `mod` item	`1d09b1dc7f381509b4a07e9e6ff20bccfc0f6fce` (link)
#151282	THIR patterns: Explicitly distinguish `&pin` from plain `&`…	`6ff26de686ad88a27c74edb8b4267d8b7fc2820b` (link)
#151516	Do not emit errors on non-metaitem diagnostic attr input	`5d666fd7ac534707cf58e74050a95a5674a1eb23` (link)
#151593	miri subtree update	`9fbb9471960a2a3e83d890d03c996f1593ad5635` (link)

previous master: a18e6d9d14

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-01-24T18:09:28Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a18e6d9 (parent) -> 021fc25 (this PR)

Test differences

Show 112 test diffs

Stage 1

[ui] tests/ui/consts/const-block-item-macro-codegen.rs: pass -> [missing] (J1)
[ui] tests/ui/consts/const-block-item.rs: pass -> [missing] (J1)
[ui] tests/ui/consts/const-block-items/assert-fail.rs: [missing] -> pass (J1)
[ui] tests/ui/consts/const-block-items/assert-pass.rs: [missing] -> pass (J1)
[ui] tests/ui/consts/const-block-items/hir.rs: [missing] -> pass (J1)
[ui] tests/ui/consts/const-block-items/typecheck.rs: [missing] -> pass (J1)
[ui] tests/ui/consts/const-item-with-block-body/macro-codegen.rs: [missing] -> pass (J1)
[ui] tests/ui/consts/const-item-with-block-body/static.rs: [missing] -> pass (J1)
[ui] tests/ui/feature-gates/feature-gate-const-block-items.rs: [missing] -> pass (J1)
[ui] tests/ui/parser/const-block-items/attrs.rs: [missing] -> pass (J1)
[ui] tests/ui/parser/const-block-items/inner-attr.rs: [missing] -> pass (J1)
[ui] tests/ui/parser/const-block-items/macro-item.rs: [missing] -> pass (J1)
[ui] tests/ui/parser/const-block-items/macro-stmt.rs: [missing] -> pass (J1)
[ui] tests/ui/parser/const-block-items/mod-in-fn.rs: [missing] -> pass (J1)
[ui] tests/ui/parser/const-block-items/pub.rs: [missing] -> pass (J1)
[ui] tests/ui/parser/const-block-items/unsafe.rs: [missing] -> pass (J1)
[ui] tests/ui/pin-ergonomics/user-type-projection.rs: [missing] -> pass (J1)

Stage 2

[ui] tests/ui/consts/const-block-item-macro-codegen.rs: pass -> [missing] (J0)
[ui] tests/ui/consts/const-block-item.rs: pass -> [missing] (J0)
[ui] tests/ui/consts/const-block-items/assert-fail.rs: [missing] -> pass (J0)
[ui] tests/ui/consts/const-block-items/assert-pass.rs: [missing] -> pass (J0)
[ui] tests/ui/consts/const-block-items/hir.rs: [missing] -> pass (J0)
[ui] tests/ui/consts/const-block-items/typecheck.rs: [missing] -> pass (J0)
[ui] tests/ui/consts/const-item-with-block-body/macro-codegen.rs: [missing] -> pass (J0)
[ui] tests/ui/consts/const-item-with-block-body/static.rs: [missing] -> pass (J0)
[ui] tests/ui/feature-gates/feature-gate-const-block-items.rs: [missing] -> pass (J0)
[ui] tests/ui/parser/const-block-items/attrs.rs: [missing] -> pass (J0)
[ui] tests/ui/parser/const-block-items/inner-attr.rs: [missing] -> pass (J0)
[ui] tests/ui/parser/const-block-items/macro-item.rs: [missing] -> pass (J0)
[ui] tests/ui/parser/const-block-items/macro-stmt.rs: [missing] -> pass (J0)
[ui] tests/ui/parser/const-block-items/mod-in-fn.rs: [missing] -> pass (J0)
[ui] tests/ui/parser/const-block-items/pub.rs: [missing] -> pass (J0)
[ui] tests/ui/parser/const-block-items/unsafe.rs: [missing] -> pass (J0)
[ui] tests/ui/pin-ergonomics/user-type-projection.rs: [missing] -> pass (J0)

Additionally, 78 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 021fc25b7a48f6051bee1e1f06c7a277e4de1cc9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-aarch64-apple: 8977.8s -> 6437.3s (-28.3%)
pr-check-1: 1521.9s -> 1925.8s (+26.5%)
aarch64-apple: 8283.3s -> 9834.6s (+18.7%)
i686-gnu-nopt-1: 7042.7s -> 8277.5s (+17.5%)
x86_64-gnu-llvm-21-3: 5979.5s -> 6841.4s (+14.4%)
aarch64-gnu-debug: 3935.6s -> 4449.2s (+13.1%)
pr-check-2: 2253.8s -> 2503.5s (+11.1%)
aarch64-gnu-llvm-20-2: 2706.7s -> 3001.5s (+10.9%)
x86_64-rust-for-linux: 2789.6s -> 3093.0s (+10.9%)
i686-msvc-2: 7227.9s -> 7999.2s (+10.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-01-24T18:48:37Z

Finished benchmarking commit (021fc25): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.6%, secondary 6.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	6.5%	[6.5%, 6.5%]	1
Improvements ✅ (primary)	-2.6%	[-2.6%, -2.6%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.6%	[-2.6%, -2.6%]	1

Cycles

Results (primary 0.7%, secondary 3.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.7%, 0.7%]	1
Regressions ❌ (secondary)	3.3%	[2.6%, 3.9%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[0.7%, 0.7%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 469.207s -> 472.296s (0.66%)
Artifact size: 383.51 MiB -> 383.54 MiB (0.01%)

@ghost

…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#149174 (`const` blocks as a `mod` item) - rust-lang#151282 (THIR patterns: Explicitly distinguish `&pin` from plain `&`/`&mut`) - rust-lang#151593 (miri subtree update) - rust-lang#151516 (Do not emit errors on non-metaitem diagnostic attr input) r? @ghost

Zalathar and others added 30 commits January 20, 2026 13:41

THIR patterns: Explicitly distinguish &pin from plain &/&mut

566c23d

Prepare for merging from rust-lang/rust

2b0f119

This updates the rust-version file to 63f4513.

fmt

ff5a250

make comment consistent

24e28e7

Merge pull request rust-lang#4820 from rust-lang/rustup-2026-01-20

0aac6d1

Automatic Rustup

Prepare for merging from rust-lang/rust

47f3474

This updates the rust-version file to d276646.

Merge pull request rust-lang#4822 from rust-lang/rustup-2026-01-21

569b4f9

Automatic Rustup

Sugar for const _: () =

8439fda

separate ast item for const block items

61ac562

Audit AllowConstBlockItems

5eb0193

const_block_items: tests

e77b119

const_block_items: do not create an AnonConst

a315d23

Compile-time variant of shim_sig_arg

a378a56

Merge pull request rust-lang#4806 from CraftSpider/comp-sig

b22c2f9

Compile-time variant of shim_sig_arg

Add test for libc opendir and closedir

c84eced

Do not emit errors on non-metaitem diagnostic attr input

215a82c

Prepare for merging from rust-lang/rust

9b30ff4

This updates the rust-version file to d10ac47.

Merge pull request rust-lang#4825 from rust-lang/rustup-2026-01-23

e4e57e5

Automatic Rustup

rustfmt: support const block items

d144915

Merge pull request rust-lang#4824 from Islam-Imad/test-libc-opendir-c…

3159e80

…losedir Add test for libc opendir and closedir

Unify readdir shim across Unix targets and add test

adeb4df

used readdir_r for mac OS

b17a22f

update .gitignore to ignore zed files

fix readdir on freebsd, and minor tweaks

4cd367f

Merge pull request rust-lang#4821 from Islam-Imad/refactor/readdir

24ced66

Unify readdir across Unix targets and add test

error on DuplicateHandle of pseudo handle

3c03d82

readdir: also emit the special directory entries . and ..

1d85118

add test for DuplicateHandle on a pseudo handle

7a937ae

RalfJung and others added 6 commits January 24, 2026 11:19

Merge pull request rust-lang#4829 from RalfJung/readdir-special

1046e2f

readdir: also emit the special directory entries . and ..

Merge pull request rust-lang#4818 from beepster4096/psuedohandling

a3d2e99

windows shims: throw unsupported error for DuplicateHandle on pseudo handle

Rollup merge of rust-lang#151593 - RalfJung:miri, r=RalfJung

9511130

miri subtree update Subtree update of `miri` to rust-lang/miri@d4afb41. Created using https://github.com/rust-lang/josh-sync. r? @ghost

Rollup merge of rust-lang#151516 - mejrs:ignore_nonmeta, r=jdonszelma…

ac8e7f2

…nn,jonathanbrouwer Do not emit errors on non-metaitem diagnostic attr input This unblocks porting over diagnostic attributes by properly addressing rust-lang#151056 (comment) r? @JonathanBrouwer

rust-bors bot added the rollup A PR which is a rollup label Jan 24, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 24, 2026

rust-bors bot merged commit 021fc25 into rust-lang:main Jan 24, 2026
12 checks passed

rustbot added this to the 1.95.0 milestone Jan 24, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 4 pull requests#151594

Rollup of 4 pull requests#151594
rust-bors[bot] merged 36 commits intorust-lang:mainfrom
matthiaskrgr:rollup-sAb1Qar

matthiaskrgr commented Jan 24, 2026

Uh oh!

matthiaskrgr commented Jan 24, 2026

Uh oh!

rust-bors bot commented Jan 24, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 24, 2026

Uh oh!

Uh oh!

rust-timer commented Jan 24, 2026

Uh oh!

github-actions bot commented Jan 24, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Jan 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

matthiaskrgr commented Jan 24, 2026

Uh oh!

matthiaskrgr commented Jan 24, 2026

Uh oh!

rust-bors bot commented Jan 24, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Jan 24, 2026

Uh oh!

Uh oh!

rust-timer commented Jan 24, 2026

Uh oh!

github-actions bot commented Jan 24, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Jan 24, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants